Skip to content

Conversation

vieiro
Copy link
Collaborator

@vieiro vieiro commented Nov 7, 2024

Update github workflow and README.adoc

Signed-off-by: Antonio Vieiro [email protected]

@vieiro vieiro requested a review from jmtd November 7, 2024 17:20
@sefroberg sefroberg self-requested a review November 7, 2024 17:42
@vieiro vieiro force-pushed the features/OPENJDK-3418 branch 2 times, most recently from 8418ed7 to af87e20 Compare November 8, 2024 11:54
@jerboaa
Copy link
Contributor

jerboaa commented Nov 8, 2024

GHA fails with

ERROR Descriptor ('openjdk-11-rhel-9.yaml') could not be found on the path, please check your arguments!

The descriptor in this patch is openjdk-11-rhel9.yaml

Update github workflow and README.adoc

Signed-off-by: Antonio Vieiro <[email protected]>
@vieiro vieiro force-pushed the features/OPENJDK-3418 branch from af87e20 to 62c332d Compare November 8, 2024 14:10
@vieiro
Copy link
Collaborator Author

vieiro commented Nov 8, 2024

Hi @jmtd @sefroberg,
Ready for review now. I've commented out the failing behave tests (we may improve them later on).
Apologies for the force pushes (this is something I'm used to in other projects where squashes are not welcome).

Copy link

@sefroberg sefroberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we figure out the behave tests next week, I think this looks correct.

@@ -2,9 +2,9 @@ name: UBI9 OpenJDK 11 S2I Image CI
on: [push, pull_request]
env:
LANG: en_US.UTF-8
IMAGE: ubi9-openjdk-11
IMAGE: openjdk-11-rhel-9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would seem this PR proves that this env var definition here is not in use.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very true!

@jmtd jmtd merged commit 5118276 into rh-openjdk:jdk11-els-rhel9 Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants