-
Notifications
You must be signed in to change notification settings - Fork 61
[OPENJDK-3542] Rename ubi9/openjdk21 images to reflect tech preview #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of inline comments to address, but otherwise looks great. Also good catch on test tagging. I'll file a follow-up JIRA to check the rest.
modules/jlink/artifacts/opt/jboss/container/java/jlink/mkdeps.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating on this so fast. A couple more nits to resolve.
Addresses https://issues.redhat.com/browse/OPENJDK-3542
This renames the UBI9/Openjdk21 and corresponding runtime image to reflect it's status as a tech preview image for the jlink-dev branch. The name used is the one tentatively decided by OPENJDK-3543 (openjdk-tech-preview/openjdk-21-jlink-rhel9), as that issue is still marked as in review this one could change accordingly.
There's one reference left to ubi9/openjdk-21 in the community imagestreams json, I left that one alone since the spec points towards registry.access.redhat.com/ubi9/openjdk-21:1.17 as the source for it. I'm not sure where our tech preview image will eventually be located so it's probably best to leave this part alone for now? I can rename the imagestream if needed though.