Skip to content

Conversation

Josh-Matsuoka
Copy link
Contributor

Addresses https://issues.redhat.com/browse/OPENJDK-3542

This renames the UBI9/Openjdk21 and corresponding runtime image to reflect it's status as a tech preview image for the jlink-dev branch. The name used is the one tentatively decided by OPENJDK-3543 (openjdk-tech-preview/openjdk-21-jlink-rhel9), as that issue is still marked as in review this one could change accordingly.

There's one reference left to ubi9/openjdk-21 in the community imagestreams json, I left that one alone since the spec points towards registry.access.redhat.com/ubi9/openjdk-21:1.17 as the source for it. I'm not sure where our tech preview image will eventually be located so it's probably best to leave this part alone for now? I can rename the imagestream if needed though.

@Josh-Matsuoka Josh-Matsuoka requested a review from jmtd January 20, 2025 21:00
Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of inline comments to address, but otherwise looks great. Also good catch on test tagging. I'll file a follow-up JIRA to check the rest.

@Josh-Matsuoka Josh-Matsuoka requested a review from jmtd January 21, 2025 16:47
Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this so fast. A couple more nits to resolve.

@Josh-Matsuoka Josh-Matsuoka requested a review from jmtd January 22, 2025 14:54
@jmtd jmtd merged commit 090f253 into rh-openjdk:jlink-dev Jan 23, 2025
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants