[OPENJDK-3637] clean up correct hsperfdata path #542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hsperfdata path is determined by the running user's username. This is no longer "jboss", but "default". Use "${USER}" so that we catch any future changes in username.
https://issues.redhat.com/browse/OPENJDK-3637
This is quite hard to write a Behave test for. We need to perform an S2I build that invokes maven, which in turn invokes java, to create a
hsperfdata
directory. Then, we need to start a new container instance from the output of S2I, but override CMD so that the payload (java) doesn't start (which would create it's ownhsperfdata
), in order to test for its presence or absence. There aren't the right steps in https://github.com/cekit/behave-test-steps to pull this off. I started writingt some but they'll take some work to get right.