Skip to content

Conversation

Josh-Matsuoka
Copy link
Contributor

Addresses https://issues.redhat.com/browse/OPENJDK-3634

Brings over the work done in 884c621 , Updates the image name in jlink template to reflect it's tech-preview status and the new name of the jlink container. Also bumps up the recommended/example JDK version to 21.

@Josh-Matsuoka Josh-Matsuoka requested a review from jmtd February 18, 2025 21:00
Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline messages

@Josh-Matsuoka Josh-Matsuoka requested a review from jmtd February 26, 2025 03:38
@sefroberg
Copy link

We should not be over writing the existing ubi9-jdk21 image but adding a new file here. I don't see how what we are doing is going to save us any time or effort in the short, medium or long-term. In the long term, it will make attempting to merge this branch back into the UBI9 branch impossible.

@jmtd
Copy link
Member

jmtd commented Feb 27, 2025

Hi @sefroberg

can you expand on what the problems are?

In the long term, it will make attempting to merge this branch back into the UBI9 branch impossible.

In the future if we are looking at merging jlink-dev down to ubi9, that is presumably because we are moving the feature from Tech Preview to GA. In which case, we'd want the changes in the main UBI9/21 image, rather than in a separate TP image, which would be going away at that point. We would need to revert the image name changes at that point, and make various other changes. But in either case the changes needed to the image YAML are tiny.

@jmtd
Copy link
Member

jmtd commented Feb 27, 2025

Also to be clear the image changes are already merged, happy to have that discussion but this PR doesn't touch the image YAMLs.

@jmtd
Copy link
Member

jmtd commented Feb 27, 2025

@Josh-Matsuoka I'm reviewing this now but please take a look at resolving merge conflicts: something has changed in jlink-dev since you forked for this. Thanks!

Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (subject to resolving merge conflicts)

@Josh-Matsuoka Josh-Matsuoka merged commit 8e77d86 into rh-openjdk:jlink-dev Feb 28, 2025
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants