-
Notifications
You must be signed in to change notification settings - Fork 61
[OPENJDK-3634] update image name in jlink template #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see inline messages
We should not be over writing the existing ubi9-jdk21 image but adding a new file here. I don't see how what we are doing is going to save us any time or effort in the short, medium or long-term. In the long term, it will make attempting to merge this branch back into the UBI9 branch impossible. |
Hi @sefroberg can you expand on what the problems are?
In the future if we are looking at merging |
Also to be clear the image changes are already merged, happy to have that discussion but this PR doesn't touch the image YAMLs. |
@Josh-Matsuoka I'm reviewing this now but please take a look at resolving merge conflicts: something has changed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (subject to resolving merge conflicts)
Addresses https://issues.redhat.com/browse/OPENJDK-3634
Brings over the work done in 884c621 , Updates the image name in jlink template to reflect it's tech-preview status and the new name of the jlink container. Also bumps up the recommended/example JDK version to 21.