Skip to content

Conversation

jmtd
Copy link
Member

@jmtd jmtd commented Mar 4, 2025

Some behavioural change (S2I_ENABLE_JLINK is not echoed in the logs); fix syntax of final test; adjust approach used to check for the presence or absence of files and directories.

https://issues.redhat.com/browse/OPENJDK-3647

@jmtd jmtd requested a review from Josh-Matsuoka March 4, 2025 11:40
Some behavioural change (S2I_ENABLE_JLINK is not echoed in the logs);
fix syntax of final test; adjust approach used to check for the presence
or absence of files and directories.

Signed-off-by: Jonathan Dowland <[email protected]>
@jmtd jmtd force-pushed the 3647-adjust-tests branch from e9b457a to 31708a3 Compare March 4, 2025 14:31
Copy link

@sefroberg sefroberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jmtd jmtd merged commit 3a410cb into rh-openjdk:jlink-dev Mar 5, 2025
0 of 6 checks passed
@jmtd jmtd deleted the 3647-adjust-tests branch March 5, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants