[OPENJDK-2968] Runtime images don't properly support JAVA_ARGS #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes for current builders, fails for current runtimes. https://issues.redhat.com/browse/OPENJDK-2968 Signed-off-by: Jonathan Dowland <[email protected]>
This was used in the RHEL7 images but not since. Signed-off-by: Jonathan Dowland <[email protected]>
Don't touch $JAVA_ARGS in s2i/run, leave that responsibility to run-java.sh. <https://issues.redhat.com/browse/OPENJDK-2968> Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
force-pushed
the
OPENJDK-2968-JAVA_ARGS_runtime-ubi9
branch
from
f2449f2 to
24f6317
Compare
jmtd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime images do not honour
JAVA_ARGS, as it is being handled bys2i/runinstead ofrun-java.shfor some reason. Move the handling intorun-java.shso it is shared with the runtime images.(Originally an adaptation of WIP work from #492 to ubi9.)
https://issues.redhat.com/browse/OPENJDK-2968