[OPENJDK-3935] Fix script permissions for artifacts #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to add more behave tests to thoroughly check the relevant scripts are executable. |
https://issues.redhat.com/browse/OPENJDK-3935 Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
force-pushed
the
OPENJDK-3935-artifact-permissions
branch
from
195d5f4 to
56dc013
Compare
This adds tests to ensure certain scripts have the correct permissions. https://issues.redhat.com/browse/OPENJDK-3935 Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
force-pushed
the
OPENJDK-3935-artifact-permissions
branch
from
56dc013 to
c7f38c1
Compare
jerboaa
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#583 caused an unintended break for images built on OSBS. For other build types, things worked as expected, but for OSBS builds the file permissions for copied-in files (which are round tripped through the dist-git lookaside cache) lacked +x permissions where they were needed.
This is a -- hopefully temporary -- fix that re-introduces some
configure.shscripts to force permissions, and some behave test to check that they applied correctly.The longer-term fix is to be via cekit/cekit#944
https://issues.redhat.com/browse/OPENJDK-3935