[OPENJDK-3975] tests for custom configuration and data #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI results (after test commit push, before fix commit push): builders fail (as expected) |
|
17 runtime fail is sporadic unrelated |
|
Hey @jerboaa , shipping 1.23 has been slightly delayed, and since we will now get at least one test failure on any change until this PR is merged, I'm wondering about making it a late edition to 1.23. WDYT? |
Signed-off-by: Jonathan Dowland <[email protected]>
Refactor the three rsync calls into a common function, adopting the fix from OPENJDK-2850 to avoid trying to change the permissions on destination directories. Signed-off-by: Jonathan Dowland <[email protected]>
jmtd
force-pushed
the
OPENJDK-3975-rsync-data-configuration
branch
from
df939db to
e2f1d59
Compare
|
rebase and force-push to resolve merge conflicts. |
|
Seems OK to me if testing looks good. |
|
The two failing checks died due to the tests-sometimes-stop-indefinitely problem on GHA. I'll run the suite on those two images locally and report back. |
|
@jerboaa JDK17 runtime: all tests passed |
|
OK to merge for me. |
jerboaa
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/OPENJDK-3975
Adjust the remaining
rsynccalls to avoid trying to change permissions on the destination directories.First, tests.