(fix) Support numeric uppercase exponent #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2025 10:51
Add unit tests for parsing JSON numbers in scientific notation (e.g., 1.23e4, 1.5e-5). These tests currently fail, exposing a bug in the JSON parser where scientific notation numbers are not properly recognized, causing parsing errors when they appear in JSON object literals. Tests cover: - Positive exponents (1.23e4) - Negative exponents (1.5e-5) - Capital E notation (2.5E+10) - Integer with exponent (3e2) - Zero exponent (4.2e0)
The tokenizer now accepts both 'e' and 'E' for scientific notation in
floating-point numbers, making it properly compliant with JSON specification
which allows both forms (e.g., 1.23e4 and 1.23E4).
The fix changes the pattern match from just 'e' to 'ch @ ('e' | 'E')' and
uses the captured character when building the result string, preserving the
original case from the input.
This resolves the parsing failures in JSON numbers with uppercase 'E' exponents.
schungx
reviewed
Oct 14, 2025
added 2 commits
October 14, 2025 12:53
Always convert uppercase 'E' to lowercase 'e' when building the number string for parsing. This normalization simplifies float parsing since the string will always use lowercase 'e' regardless of the input case. The behavior remains the same - both 'E' and 'e' are accepted in input, but internally we consistently use lowercase for parsing.
Add test cases for uppercase 'E' in scientific notation to the existing test_float_scientific test. This ensures the fix works not just for JSON parsing but for standard Rhai script evaluation as well. Tests now cover both 'e' and 'E' variants: - 1.23456E2 - 1.23456E+2 - 123456E-3
BrynCooke
changed the title
schungx
reviewed
Oct 14, 2025
This was referenced Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1038
Summary
Fixes numeric parsing to support uppercase 'E' in scientific notation numbers (e.g.,
1.23E4). this affects parse_json and regular rhai scripts.This is particularly relevant to JSON parsing as uppercase
Eis allowed by the JSON spec, so currently valid JSON fails to parse.Changes