Skip to content
This repository was archived by the owner on Jan 27, 2026. It is now read-only.

Push to talk#82

Open
llluis wants to merge 6 commits intorhasspy:masterfrom
llluis:push-to-talk
Open

Push to talk#82
llluis wants to merge 6 commits intorhasspy:masterfrom
llluis:push-to-talk

Conversation

@llluis
Copy link
Contributor

@llluis llluis commented Jan 23, 2024

This is a first try on implementing #5 push to talk for review.
I'm pretty confident on the satellite side (bi-directional event service) but not so sure on the 2mic side with the callback and async. Instead of trying to find the perfect solution, I'm posting here so more people can review and test.

There's also minor changes in logging to help folks troubleshoot as per some of the open issues.

@llluis
Copy link
Contributor Author

llluis commented Jan 23, 2024

Got scared by the failed test.
It did catch a bug but also had to be adjusted... Now I'm confident again :)

@qJake
Copy link

qJake commented Aug 4, 2024

Will this allow assist activation from a button press / service call from HA? If so, I'd be willing to test this, as I'm very interested in getting that to work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants