Option to record entire window#2
Conversation
|
@edridgedsouza thanks for the PR. Sorry I did not reply earlier, I was not receiving notifications for this repo. |
rhcarvalho
left a comment
rhcarvalho
left a comment
There was a problem hiding this comment.
Thanks for the improvements. There is still a conflict, to solve it you can rebase on top of rhcarvalho/master. If you need help with that, I'd be happy to assist you.
|
|
||
| # Standard screencast folder | ||
| FOLDER="$HOME/Pictures" | ||
| FOLDER=$(xdg-user-dir PICTURES 2>/dev/null || echo "$HOME/Pictures")/ByzanzGif |
There was a problem hiding this comment.
Was it a problem to drop the files into ~/Pictures? I'd prefer to keep ~/Pictures or have it configurable. We could make all of these "constants" read from the environment and use user-provided input if that's something useful.
Example:
FOO="${FOO-default}"
FOLDER="${FOLDER-$(xdg-user-dir PICTURES 2>/dev/null || echo "$HOME/Pictures")}"
(note: I didn't test the above, there might be a mistake or two ;) )
| # AUTHOR: (c) Rob W 2012 | ||
| # modified by MHC (http://askubuntu.com/users/81372/mhc) | ||
| # and by Rodolfo Carvalho | ||
| # and by Edridge D'Souza |
There was a problem hiding this comment.
I think here we might have a case of tabs x spaces, that's why it looks misaligned?
| echo "Recording duration set to $D seconds. Recording will start in $DELAY seconds." | ||
|
|
||
| #Actual recording | ||
| espeak "Starting in $DELAY seconds." |
| beep | ||
| espeak "Start" | ||
|
|
||
| if [ $TITLE = "unity-panel" ]; then |
There was a problem hiding this comment.
Is there a way we could check for DE/WM == unity, in addition to the window title?
Could you please add a note about this feature to the README? Thanks!
2 participants
I made a couple of changes:
if you click the unity titlebar, it'll record the entire screen, including the titlebar and dock (Unity only, not tested on other DE's)
Uses espeak instead of a notification sound
Changed some notifications to simple terminal outputs so they don't interfere with the recording