Merged
Conversation
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
elai-shalev
reviewed
Aug 25, 2025
Collaborator
elai-shalev
left a comment
elai-shalev
left a comment
There was a problem hiding this comment.
Looks good.
I like the api_curl
just recommending - maybe add a sanity example with our pre-existing greeting workflow or other workflow that are known to RHDH people. e.g try to recreate it / validate it / use it.
Collaborator
Author
|
The examples is in their way, but we need to get it working before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.