feat: add workflow compilation#12
Merged
eloycoto merged 1 commit intorhdhorchestrator:masterfrom Aug 26, 2025
Merged
Conversation
Signed-off-by: Eloy Coto <eloy.coto@acalustra.com>
eloycoto
force-pushed
the
Orchestrator-compilation
branch
from
4cbbcfa to
d6997a2
Compare
elai-shalev
reviewed
Aug 26, 2025
Comment on lines
+54
to
+55
| except OSError: | ||
| pass |
Collaborator
There was a problem hiding this comment.
should this be completed?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure what do you mean here. Like we try to remove, if not, what can be done? I mean, we don't want to break the server at all
| f.write(workflow) | ||
|
|
||
| cmd = get_command() + [workflow_path] | ||
| result = subprocess.run(cmd, capture_output=True, text=True, timeout=30) |
Collaborator
There was a problem hiding this comment.
error handeling on sub process?
Collaborator
Author
There was a problem hiding this comment.
it's alredy in the try catch, and we handle the output: success = result.returncode == 0
return success, logs
elai-shalev
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.