generateOperationId should transform path to an OpenApi path#213
Merged
MathurAditya724 merged 1 commit intorhinobase:mainfrom Jan 20, 2026
Merged
Conversation
commit: |
MathurAditya724
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
generateOperationIdgets passed the hono path but handles it as it would be a an OpenApi path without actually transforming it. Therefore, the operationId can contain colons for paths with path parameters as the implemented handling for path parameters never gets called.This PR adds the transformation of the hono path to an OpenApi path before the special handling for path parameters is done and the path is transformed to an operationId.
This change also solves other edge cases like optional path parameters and RegExp as those are already handled by
toOpenAPIPath(rather the extractedtoOpenAPIPathSegment)