network: run some dependency tests on cockpit PRs

[rvykydal]

We don't need to run special vm setup (like "bootopts-net1") network tests on Cockpit PRs, the standard setup should be fine to guard Cockpit networkmanager module changes.

More fine-grained approach (cockpit-storage and cockpit-network scenarios and matrix based on changes files in https://github.com/cockpit-project/cockpit/blob/6d1a45bcac8e5ff4343bbe7c58405f62bf43c003/.github/workflows/trigger-anaconda.yml) is out of scope of this PR.

Related Cockpit PR: cockpit-project/cockpit#22934

Resolves: INSTALLER-4625

[gemini-code-assist]

Summary of Changes

Hello @rvykydal, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the execution of network tests for Cockpit-related changes by focusing them on a standard VM setup. The modifications ensure that specialized, broader network test configurations are not unnecessarily triggered for Cockpit PRs, thereby optimizing the testing pipeline and ensuring that relevant tests are run efficiently without redundant setups.

Highlights

• Test Method Renaming: Renamed testConnectionsPreInstall to testCockpitConnectionsPreInstall and testConfigurationPreInstall to testCockpitConfigurationPreInstall within test/check-network to explicitly link these tests to Cockpit functionality.
• Test Setup Simplification: Adjusted the @run_on_vm_setups decorator in test/check-network to ensure network tests for Cockpit PRs are run only on the bootopts-net1 VM setup, removing the previously commented-out option for additional setups.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Activity

• No specific activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request renames two test methods in test/check-network by prefixing them with Cockpit. This change appears to be for including them in test runs for Cockpit-related pull requests that select tests by name. The changes are consistent with the existing test naming style. One of the renamed tests runs on the standard VM setup, while the other requires a special setup and would be skipped on a standard setup, which aligns with the pull request description. There appears to be a small typo in the pull request title ('sun' instead of 'run').

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[KKoukiou]

If you want all tests in this class we can also follow the patten for the cockpit storage tests. Aka rename the class to TestNetworkCockpitIntegration and leave the tests as they are

[rvykydal]

If you want all tests in this class we can also follow the patten for the cockpit storage tests. Aka rename the class to TestNetworkCockpitIntegration and leave the tests as they are

I see, remembered. I selected tests that make more sense to run on Cockpit changes. Like, they shouldn't affect for example the connections handling at the end of installation.