Skip to content

Check that allow-discards flag is set by default on LUKS2 devices#1394

Merged
rvykydal merged 1 commit intorhinstaller:mainfrom
vojtechtrefny:main_check-luks-persistent-flags
Apr 1, 2025
Merged

Check that allow-discards flag is set by default on LUKS2 devices#1394
rvykydal merged 1 commit intorhinstaller:mainfrom
vojtechtrefny:main_check-luks-persistent-flags

Conversation

@vojtechtrefny
Copy link
Copy Markdown
Contributor

@vojtechtrefny vojtechtrefny commented Mar 12, 2025

We'll need to wait for python-blivet-3.12.0-2.fc43 to make it through rawhide build magic for this to work (it should be available in tomorrows compose).

Depends on storaged-project/blivet#1347 and storaged-project/libblockdev#1095

@vojtechtrefny
Copy link
Copy Markdown
Contributor Author

The test passes with the latest rawhide ISO Fedora-Everything-netinst-x86_64-Rawhide-20250313.n.0.iso

@rvykydal
Copy link
Copy Markdown
Contributor

/test-tmt

@rvykydal
Copy link
Copy Markdown
Contributor

/test-os-variants

@rvykydal
Copy link
Copy Markdown
Contributor

/test-os-variants
https://github.com/rhinstaller/kickstart-tests/actions/runs/13854869262

We probably want to disable the test on rhel10 and rhel9, similar as in for example 2d0c58d
I think rather in this PR.

@vojtechtrefny
Copy link
Copy Markdown
Contributor Author

/test-os-variants
https://github.com/rhinstaller/kickstart-tests/actions/runs/13854869262

We probably want to disable the test on rhel10 and rhel9, similar as in for example 2d0c58d I think rather in this PR.

The fixes will be available in both 9 and 10 so I think we can wait for few more days/weeks for these to be included and then merge this.

@rvykydal
Copy link
Copy Markdown
Contributor

rvykydal commented Apr 1, 2025

/test-os-variants

Copy link
Copy Markdown
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@rvykydal rvykydal merged commit 52aaad6 into rhinstaller:main Apr 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants