Skip to content

Conversation

@rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Sep 26, 2025

In scope of the PR --testtypes launcher option is added. It extends the functionality by allowing to specify multiple comma-separated tags (The tags are defined in .sh test file in TESTTYPE variable.) Existing --testtype allows only for single tag.

The the main goal of this PR is to add useful functionality (see the INSTALLER-4293 description). Further refactoring and improvements are split out as a separate task and should be considered in the light of possible migration of test case management to TMT/FMF (so possible waste of time).

There are follow-up tasks:

  • INSTALLER-4400 Support --testtypes in anaconda repo CI /kickstart-test workflow
  • INSTALLER-4401 Support --testtypes in kickstart-tests repo CI /test-os-variants workflow
  • INSTALLER-4399 Migrate containers/runner/skip-testtypes to yaml format and move the data from generate- scripts to a data file. It is split out of this PR as separate task because: 1) of task sizing 2) the SKIP_... variables from the file were used as API (sourced in bash scripts) and we can fix possible unexpected fallouts/regressions caused by removing them in this PR easier before migration. 3) run-ci.sh depends on it 4) The migration might be superseded by migration to TMT/FMF test management.

Tested on repo branch add-testtypes-option: https://github.com/rhinstaller/kickstart-tests/actions/runs/18005730547
Based on the results of the run 3 tests are considered for re-eanabling: #1511, #1510, #1509

This option allows to select the tests by multiple tags (testtypes).

Related: INSTALLER-4293
@rvykydal rvykydal changed the title Add testtypes option Support testing of all disabled tests Sep 26, 2025
@rvykydal rvykydal force-pushed the add-testtypes-option branch from 6118734 to 606bfd7 Compare September 26, 2025 09:19
@rvykydal
Copy link
Contributor Author

/test-tmt

@rvykydal rvykydal force-pushed the add-testtypes-option branch from 606bfd7 to a365e86 Compare September 26, 2025 11:17
@rvykydal
Copy link
Contributor Author

/test-tmt

@rvykydal rvykydal marked this pull request as ready for review September 26, 2025 11:49
Copy link
Contributor

@jstodola jstodola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@rvykydal rvykydal force-pushed the add-testtypes-option branch from a365e86 to 05e54df Compare September 30, 2025 12:56
@rvykydal
Copy link
Contributor Author

Modified to run 5h after daily kickstart tests (not at the same time).

@rvykydal
Copy link
Contributor Author

/test-tmt

@rvykydal rvykydal merged commit b4d4b6c into rhinstaller:main Oct 1, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants