-
Notifications
You must be signed in to change notification settings - Fork 37
Support testing of all disabled tests #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows to select the tests by multiple tags (testtypes). Related: INSTALLER-4293
6118734 to
606bfd7
Compare
Contributor
Author
|
/test-tmt |
Related: INSTALLER-4293
606bfd7 to
a365e86
Compare
Contributor
Author
|
/test-tmt |
jstodola
approved these changes
Sep 26, 2025
Contributor
jstodola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
Related: INSTALLER-4293
a365e86 to
05e54df
Compare
Contributor
Author
|
Modified to run 5h after daily kickstart tests (not at the same time). |
Contributor
Author
|
/test-tmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of the PR
--testtypeslauncher option is added. It extends the functionality by allowing to specify multiple comma-separated tags (The tags are defined in.shtest file inTESTTYPEvariable.) Existing--testtypeallows only for single tag.The the main goal of this PR is to add useful functionality (see the INSTALLER-4293 description). Further refactoring and improvements are split out as a separate task and should be considered in the light of possible migration of test case management to TMT/FMF (so possible waste of time).
There are follow-up tasks:
--testtypesin anaconda repo CI/kickstart-testworkflow--testtypesin kickstart-tests repo CI/test-os-variantsworkflowcontainers/runner/skip-testtypestoyamlformat and move the data fromgenerate-scripts to a data file. It is split out of this PR as separate task because: 1) of task sizing 2) theSKIP_...variables from the file were used as API (sourced in bash scripts) and we can fix possible unexpected fallouts/regressions caused by removing them in this PR easier before migration. 3) run-ci.sh depends on it 4) The migration might be superseded by migration to TMT/FMF test management.Tested on repo branch add-testtypes-option: https://github.com/rhinstaller/kickstart-tests/actions/runs/18005730547
Based on the results of the run 3 tests are considered for re-eanabling: #1511, #1510, #1509