Remove add-reviewed-by-action Github Action #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Github Action has never worked and it has already been achieved with the reason "Unfortunately, this action has a critical issue with forked repositories, and should no longer be used" [1]. So remove it to also avoid noise from "Run failed: Add Reviewed-by" emails. [1] https://github.com/ntessore/add-reviewed-by-action/ Signed-off-by: Coiby Xu <[email protected]>
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
prudo1
approved these changes
Sep 11, 2025
Collaborator
prudo1
left a comment
prudo1
left a comment
There was a problem hiding this comment.
Hi @coiby,
it's unfortunate that it doesn't work but it doesn't make sense to keep it when it is broken...
While at it, I believe it would also make sense to update the integration tests in the workflow. IIUC it's using F40 for them which is EOL. So it's better to update it to F42. But that can also be done in a separate PR.
Thanks
Philipp
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Github Action has never worked and it has already been achieved with the reason "Unfortunately, this action has a critical issue with forked repositories, and should no longer be used" [1].
So remove it to also avoid noise from "Run failed: Add Reviewed-by" emails.
[1] https://github.com/ntessore/add-reviewed-by-action/