Skip to content

Commit adc0c06

Browse files
authored
add pretty value engagement (#181)
1 parent 9f383f5 commit adc0c06

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

src/main/java/com/redhat/labs/lodestar/model/Engagement.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,8 @@ public class Engagement {
9393

9494
private String region;
9595
private String type;
96+
@JsonbProperty("pretty_type")
97+
private String prettyType;
9698

9799
@JsonbProperty("categories")
98100
List<String> categoriesV2;

src/main/java/com/redhat/labs/lodestar/service/EngagementService.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ public class EngagementService {
3939

4040
@ConfigProperty(name = "commit.msg.filter.list", defaultValue = "not.set")
4141
List<String> commitFilteredMessages;
42-
43-
@ConfigProperty(name = "v2.enabled")
44-
boolean v2Enabled;
4542

4643
@Inject
4744
ParticipantService participantService;
@@ -52,6 +49,9 @@ public class EngagementService {
5249
@Inject
5350
ArtifactService artifactService;
5451

52+
@Inject
53+
ConfigService configService;
54+
5555
@Inject
5656
@RestClient
5757
EngagementApiClient engagementApiClient;
@@ -342,6 +342,9 @@ public Response getEngagementsPaged(ListFilterOptions listFilterOptions) {
342342

343343
Response response = engagementApiClient.getEngagements(page, pageSize, listFilterOptions.getV2Regions());
344344
List<Engagement> engagements = response.readEntity(new GenericType<>(){});
345+
346+
Map<String, String> engagementOptions = configService.getEngagementOptions();
347+
345348
//TODO this loop is to allow frontend to change after v2 deployment.
346349
// FE should use participant, artifact count field, and categories (string version)
347350
for(Engagement e : engagements) {
@@ -359,6 +362,8 @@ public Response getEngagementsPaged(ListFilterOptions listFilterOptions) {
359362
e.addCategory(cat);
360363
}
361364
}
365+
366+
e.setPrettyType(engagementOptions.containsKey(e.getType()) ? engagementOptions.get(e.getType()) : e.getType());
362367
}
363368
return Response.ok(engagements).header("x-total-engagements", response.getHeaderString("x-total-engagements")).build();
364369
}

0 commit comments

Comments
 (0)