Skip to content

Commit feb7d5b

Browse files
authored
get engagement only by uuid. do not use customer / project (#583)
1 parent 0a66970 commit feb7d5b

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/context/engagement_context/engagement_context.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,8 @@ export const EngagementProvider = ({
176176
const _refreshEngagementData = useCallback(
177177
async (engagement: Engagement) => {
178178
try {
179-
const refreshedEngagement = await engagementService.getEngagementByCustomerAndProjectName(
180-
engagement?.customer_name,
181-
engagement?.project_name
179+
const refreshedEngagement = await engagementService.getEngagementById(
180+
engagement?.uuid,
182181
);
183182
setCurrentEngagement(refreshedEngagement);
184183
} catch (e) {
@@ -244,6 +243,8 @@ export const EngagementProvider = ({
244243
if (!!uuid) {
245244
fetchedEngagement = await engagementService.getEngagementById(uuid);
246245
} else {
246+
//This is probably not used anymore. Check backend logs for "Deprecated get method used"
247+
//Delete this and engagementService.getEngagementByCustomerAndProjectName if none by 03/17/2022
247248
fetchedEngagement = await engagementService.getEngagementByCustomerAndProjectName(
248249
customerName,
249250
projectName

src/packages/api_v1_sdk/apiv1_engagement_service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ export class Apiv1EngagementService implements EngagementService {
135135
const {
136136
data,
137137
} = await this.axios.put(
138-
`/engagements/customers/${engagement.customer_name}/projects/${engagement.project_name}`,
138+
`/engagements/${engagement.uuid}`,
139139
{ ...serializedEngagement, commit_message: commitMessage }
140140
);
141141
return Apiv1EngagementService.engagementSerializer.deserialize(data);

0 commit comments

Comments
 (0)