Open
Conversation
ckavili
reviewed
Aug 9, 2021
|
|
||
| def createMultibranchPipelineJob(project, gitPath, jte) { | ||
| def buildNamespace = System.getenv("BUILD_NAMESPACE") ?: "labs-ci-cd" | ||
| def buildNamespace = System.getenv("BUILD_NAMESPACE") ?: "ocp-ci-cd" |
Collaborator
There was a problem hiding this comment.
can we keep this as labs-ci-cd? 🙃
| id("${project}") | ||
| remote(gitPath) | ||
| credentialsId("${buildNamespace}-${buildGitAuthSecret}") | ||
| credentialsId("${credentialsId}") |
Collaborator
There was a problem hiding this comment.
Not sure if we need this. I think, instead of defining a new SSH_ACCESS_KEY variable, you can create a secret with ssh key in it (secret type kubernetes.io/ssh-auth). It'd be the same as username/password secret. And you get to use BUILD_GIT_AUTH_SECRET and doesn't have to change credentialsId
Collaborator
There was a problem hiding this comment.
@springdo tagging you to check if you have other suggestions
Collaborator
|
hey @rsachdeva-ma thanks for the PR! I put two comments there! I'll also try and see if I can verify that SSH key part :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for bitbucket