Skip to content

Conversation

@AroneyS
Copy link
Collaborator

@AroneyS AroneyS commented Mar 31, 2025

  • test_short_read_recovery_fast
  • test_short_read_recovery_queue_submission
  • test_batch_recovery

@AroneyS AroneyS changed the base branch from main to dev March 31, 2025 01:02
@AroneyS AroneyS requested a review from Copilot March 31, 2025 01:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Snakemake integration to align with the conda environment specifications. The key changes are:

  • Updating Snakemake import paths to use "snakemake.common.configfile" from previous locations.
  • Modifying the command-line argument for Snakemake commands by appending "rules" to the "--snakemake-cmds" parameter.
  • Adjusting dependency and Python version requirements in the configuration and CI workflow files.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/test_recover.py Updated Snakemake import and modified command-line arguments in recovery tests.
test/test_assemble.py Modified command-line argument in assembly tests to include "rules".
aviary/modules/processor.py Updated import path for load_configfile to reflect new Snakemake structure.
aviary.yml Revised dependency definitions to enforce Python 3.11 and updated Snakemake version along with executor plugins.
.github/workflows/test-aviary.yml Updated Python version from 3.10 to 3.11 for CI testing.
.github/workflows/python-publish.yml Updated Python version for publish workflow from 3.10 to 3.11.
Comments suppressed due to low confidence (3)

test/test_recover.py:32

  • Verify that appending 'rules' to the '--snakemake-cmds' argument is intentional; if so, consider adding a comment or updating documentation to clarify its effect in dryrun mode.
f"--snakemake-cmds \" --quiet rules\" "

test/test_assemble.py:29

  • Ensure that the addition of 'rules' in the '--snakemake-cmds' parameter is consistent with the intended test behavior and update any supporting materials as necessary.
f"--snakemake-cmds \" --quiet rules\" "

aviary/modules/processor.py:43

  • Confirm that updating the import for load_configfile to 'snakemake.common.configfile' does not inadvertently affect other parts of the module that may rely on previous import paths.
from snakemake.common.configfile import load_configfile

@AroneyS
Copy link
Collaborator Author

AroneyS commented Mar 31, 2025

Getting this error: Ecogenomics/CheckM#411
Maybe something updated and broke in the CheckM env

@AroneyS
Copy link
Collaborator Author

AroneyS commented Nov 9, 2025

From linked issue, its likely due to OOM.

@AroneyS AroneyS closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants