test PR #10
Open
test PR #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richabanker
force-pushed
the
hackathon
branch
12 times, most recently
from
039d256 to
99ea87f
Compare
yongruilin
force-pushed
the
hackathon-yongrlin-sub1
branch
from
b058259 to
e53640a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -4357,7 +4357,7 @@ type ReplicationControllerSpec struct { | |||
| // controller. | |||
| type ReplicationControllerStatus struct { | |||
| // Replicas is the number of actual replicas. | |||
| Replicas int32 | |||
| Replicas *int32 | |||
There was a problem hiding this comment.
Changing Replicas int32 to Replicas *int32 is concerning. The original code has a required Replicas field. Changing this field to a pointer will make the Replicas field optional. If the Replicas field remains required it should not be a pointer type. If made optional, be sure a default value in all api versions is assigned.
yongruilin
force-pushed
the
hackathon-yongrlin-sub1
branch
from
e53640a to
e4472d5
Compare
| @@ -4357,7 +4357,7 @@ type ReplicationControllerSpec struct { | |||
| // controller. | |||
| type ReplicationControllerStatus struct { | |||
| // Replicas is the number of actual replicas. | |||
There was a problem hiding this comment.
Replicas should be a pointer, or it may be hard to tell the difference between zero value and being not set.
richabanker
force-pushed
the
hackathon
branch
2 times, most recently
from
2c94705 to
a535d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: