Conversation
model/gurps/skill.go
Outdated
| e := EntityFromNode(s) | ||
| level := def.SkillLevel(e, s.Replacements, true, excludes, !s.IsTechnique()) | ||
| if def.SkillBased() { | ||
| level := def.SkillLevel(e, s.Replacements, !e.SheetSettings.UseSkillTrees, excludes, !s.IsTechnique()) |
There was a problem hiding this comment.
You can't assume e has a non-nil value here
model/gurps/skill.go
Outdated
| level := def.SkillLevel(e, s.Replacements, true, excludes, !s.IsTechnique()) | ||
| if def.SkillBased() { | ||
| level := def.SkillLevel(e, s.Replacements, !e.SheetSettings.UseSkillTrees, excludes, !s.IsTechnique()) | ||
| if def.SkillBased() && e != nil && e.SheetSettings.UseSkillTrees { |
There was a problem hiding this comment.
The old code did not skip this computation if there was no entity, so this seems wrong again.
| SOMETHING=1 | ||
| ;; | ||
| --custom | -c) | ||
| --win | -w) |
There was a problem hiding this comment.
Still not grasping why this is here. I build for Windows all the time and this is not needed. Specifically, the -s option disables symbols in the output and the -w option disables DWARF generation. Both of those should only be on the command line when building for a release. By setting them, you're making debugging harder for yourself.
If you're doing this because of some oddity in your particular setup (I believe you were the one having tons of difficulty compiling on Windows for some reason), it's unclear why this would help. It shouldn't have any effect with regards to that... and if it does, it just indicates there is something fundamentally wrong in your setup.
There was a problem hiding this comment.
Hard to say, I'm very new to GO. I assumed the -w was a windows flag. I tried just -s and just -w and either and both was ok. Neither and it can't launch as an .exe for me.
There was a problem hiding this comment.
I ran into this myself after updating one of my machines to Windows 11 (previously, I had only ever built on a Windows 10 or earlier machine). Unclear why that would make a difference, or if there is something else that changed compared to my older machine that is the actual issue and not Windows 11 itself.
Regardless, one of the recent changes was to the build.sh file to get around this anomaly.
2 participants
Functionality currently limited to allowing default chaining with sheet setting selected.