Skip to content

Always include "bench" label in benchmark workflow runners and use machine-specific cache keys#66

Merged
richkcho merged 4 commits intomainfrom
copilot/add-bench-label-to-runners
Nov 28, 2025
Merged

Always include "bench" label in benchmark workflow runners and use machine-specific cache keys#66
richkcho merged 4 commits intomainfrom
copilot/add-bench-label-to-runners

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

Adjusts the benchmark workflows to ensure benchmarks only run on benchmark-capable runners and use machine-specific caching.

Changes Made

  • Runner Labels: Modified runner label building to always include "bench" alongside "self-hosted" (similar to how "self-hosted" was already always included). The runner_labels input now only accepts additional labels beyond the required ones.
  • Cache Keys: Changed cache keys from inputs.runner_labels to runner.name to ensure machine-specific caching, since different machines may have different performance characteristics.
  • Bug Fix: Corrected pre-existing typos where inputs.runner_label (singular) was used instead of inputs.runner_labels (plural) in 6 places across both workflow files.

These changes are made in both bench-mpmc.yml and bench-spsc.yml workflow files.

Validation

  • ✅ actionlint passes with no issues
  • ✅ Code review passed
  • ✅ Security scanning shows no alerts
Original prompt

adjust the benchmark workflows to add the "bench" label to selected runners by default. we only want to run the benchmark workflows on benchmark capable runners.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: richkcho <6968981+richkcho@users.noreply.github.com>
Copilot AI changed the title [WIP] Adjust benchmark workflows to add bench label to selected runners Add "bench" label as default for benchmark workflow runners Nov 28, 2025
Copilot AI requested a review from richkcho November 28, 2025 04:01
@richkcho richkcho marked this pull request as ready for review November 28, 2025 06:44
@richkcho
Copy link
Owner

@copilot please review and fix the reviewdog comments on the PR.

…abels

Co-authored-by: richkcho <6968981+richkcho@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

@copilot please review and fix the reviewdog comments on the PR.

Fixed the actionlint issues in commit e664c3b. The problems were pre-existing typos: inputs.runner_label (singular) should have been inputs.runner_labels (plural) in 6 places across both workflow files (cache keys and shared-key configurations).

@richkcho
Copy link
Owner

stamp pls

@richkcho
Copy link
Owner

Let's change this to have bench be a label that will always be included, like "self-hosted". Also, the key for caching should be something unique to the machine, since machines may have different characteristics.

@richkcho
Copy link
Owner

Let's change this to have bench be a label that will always be included, like "self-hosted". Also, the key for caching should be something unique to the machine, since machines may have different characteristics.
@copilot please take a look

Co-authored-by: richkcho <6968981+richkcho@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

Let's change this to have bench be a label that will always be included, like "self-hosted". Also, the key for caching should be something unique to the machine, since machines may have different ch...

Done in commit bea001c. The "bench" label is now always included in runner selection (like "self-hosted"), and cache keys now use runner.name for machine-specific caching.

Copilot AI changed the title Add "bench" label as default for benchmark workflow runners Always include "bench" label in benchmark workflow runners and use machine-specific cache keys Nov 28, 2025
@richkcho richkcho merged commit aee7b28 into main Nov 28, 2025
1 check passed
@richkcho richkcho deleted the copilot/add-bench-label-to-runners branch November 28, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants