Imply @NativeCoroutinesIgnore when container is @HiddenFromObjC #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolaykasyanov
commented
Dec 30, 2025
| !annotation.isNativeCoroutinesAnnotation(session) && annotation.isRefinementAnnotation(session) | ||
| } | ||
|
|
||
| internal fun FirClassLikeDeclaration.isRefined(session: FirSession): Boolean = |
Author
There was a problem hiding this comment.
isRefined is probably not the best name here as types can't be annotated with @RefinesInSwift, so the only option is @HidesFromObjC.
nikolaykasyanov
commented
Dec 30, 2025
| val annotations = declaration.getNativeCoroutinesAnnotations(context.session) | ||
| val isRefined = declaration.isRefined(context.session) | ||
| val isRefined = | ||
| declaration.isRefined(context.session) || (declaration.getContainingClass()?.isRefined(context.session) |
Author
There was a problem hiding this comment.
On the second thought, the whole containment chain needs to be checked for cases where the top-level class is hidden & nested classes have suspend functions/flows.
rickclephas
approved these changes
Jan 7, 2026
Owner
rickclephas
left a comment
rickclephas
left a comment
There was a problem hiding this comment.
Looks good, thanks!
I find this PR helpful on its own, but ideally something like this should lead to a warning:
Yeah that would indeed be nice, I'll take a look 👍🏻 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #164 to suppress exposed suspend function/flow warnings when the containing type is annotated with an annotation that
@HidesFromObjC.I find this PR helpful on its own, but ideally something like this should lead to a warning:
Happy New Year! 🎉