Add hostname support for docker runners#406
Merged
guenhter merged 1 commit intoriemers:masterfrom Oct 20, 2025
Merged
Conversation
Collaborator
|
I guess the if checks should be checked with explicit boolean checks. |
59a2a57 to
089d26b
Compare
089d26b to
cb64030
Compare
Contributor
Author
|
@guenhter like that? |
Collaborator
|
LGTM |
Collaborator
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i needed a way to set the hostname of gitlab runners, so i have added the docker_hostname variable to set the hostname in the docker containers.