fix: remove lonely quote breaking the filename#408
Merged
guenhter merged 1 commit intoriemers:masterfrom Oct 31, 2025
Merged
Conversation
Contributor
Author
|
Converting to draft till my local tests are over |
gwarf
force-pushed
the
fix_quote_filename
branch
from
08e4b9a to
fd72257
Compare
Contributor
Author
|
OK, now it works for me. Out of curiosity I tested adding the double quotes around, but it broke, so I reverted 😅 I'm personally not fond of the convoluted test in the variable declaration, I find it not enough instinctive (maybe also due to indentation/formatting) but I don't have much time to invest in testing the container part and I don't want to break it, so will leave it as it is. |
Collaborator
|
LGTM |
guenhter
approved these changes
Oct 31, 2025
Contributor
Author
|
@riemers would you be so kind t make a new release so that the latest tag will be in a working state? Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit 4929c82#diff-23e21b6c89468f7534697ad091835b3ee5e0213b37ace489488234e5a9548ec4R29 introduced in #405 included a lonely double quote at the end, when testing while using the template-based configuration, it creates a new file
/etc/gitlab-runner/config.toml"