You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes an issue introduced in #404. The Ensure Gitlab runner repository GPG key is readable by everyone Task is trying to check a file that might not exist, which causes the role to fail on fresh installations.
This PR makes the keyring-path that is checked configurable, but defaults to the path provided by the official gitlab-runner script mentioned in the GitLab Docs.
FTR, I only installed and configured the runner with this Ansible role, didn't do any manual setup.
I just saw these issues in the upstream, so it seems the script may have had changes/issues.
Unfortunately, after some quick search, I haven't been able to find an authoritative repo with the source of the script to see if it got changed or if I really messed up from my side:
@gwarf no worries. I also searched for the scripts source and wasn't able to find it, not sure where GitLab is hiding that...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced in #404. The
Ensure Gitlab runner repository GPG key is readable by everyoneTask is trying to check a file that might not exist, which causes the role to fail on fresh installations.This PR makes the keyring-path that is checked configurable, but defaults to the path provided by the official gitlab-runner script mentioned in the GitLab Docs.
Fixes the fix for #397 ;)