Skip to content

Fix: Gitlab runner repository GPG key permission check by making keyring-path configurable#414

Merged
guenhter merged 3 commits intoriemers:masterfrom
IQNeoXen:master
Dec 3, 2025
Merged

Fix: Gitlab runner repository GPG key permission check by making keyring-path configurable#414
guenhter merged 3 commits intoriemers:masterfrom
IQNeoXen:master

Conversation

@IQNeoXen
Copy link
Copy Markdown

@IQNeoXen IQNeoXen commented Dec 2, 2025

This PR fixes an issue introduced in #404. The Ensure Gitlab runner repository GPG key is readable by everyone Task is trying to check a file that might not exist, which causes the role to fail on fresh installations.

This PR makes the keyring-path that is checked configurable, but defaults to the path provided by the official gitlab-runner script mentioned in the GitLab Docs.

Fixes the fix for #397 ;)

@IQNeoXen
Copy link
Copy Markdown
Author

IQNeoXen commented Dec 2, 2025

I just realized this was fixed in #413 🤦
I still like this configurable variant more though.

@IQNeoXen IQNeoXen changed the title Fix: Gitlab runner repository GPG key permission check Fix: Gitlab runner repository GPG key permission check by making keyring-path configurable Dec 2, 2025
@guenhter
Copy link
Copy Markdown
Collaborator

guenhter commented Dec 3, 2025

LGTM.

@guenhter guenhter merged commit 2411c76 into riemers:master Dec 3, 2025
1 check passed
@guenhter
Copy link
Copy Markdown
Collaborator

guenhter commented Dec 3, 2025

Thx for this contribution. Having it configurable is definitely a good thing.

@gwarf
Copy link
Copy Markdown
Contributor

gwarf commented Dec 3, 2025

FTR, I only installed and configured the runner with this Ansible role, didn't do any manual setup.
I just saw these issues in the upstream, so it seems the script may have had changes/issues.
Unfortunately, after some quick search, I haven't been able to find an authoritative repo with the source of the script to see if it got changed or if I really messed up from my side:

Sorry if it created some issues, and thanks for everyone working on keeping this role up-to-date and working :)

@IQNeoXen
Copy link
Copy Markdown
Author

IQNeoXen commented Dec 8, 2025

@gwarf no worries. I also searched for the scripts source and wasn't able to find it, not sure where GitLab is hiding that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants