Skip to content

Refactoring & cleanup in routes & route groups + bug fixes#1881

Merged
tomasherceg merged 6 commits intomainfrom
bug/route-groups
Apr 26, 2025
Merged

Refactoring & cleanup in routes & route groups + bug fixes#1881
tomasherceg merged 6 commits intomainfrom
bug/route-groups

Conversation

@tomasherceg
Copy link
Copy Markdown
Member

@tomasherceg tomasherceg commented Nov 3, 2024

We had several issues in route groups when used in combination with URL and route redirections:

config.RouteTable.AddGroup(
    "CmsAdmin", urlPrefix, "embedded://Shared.Infrastructure.Cms.Admin", routes =>
{
    routes.AddRouteRedirection(
        "Index", 
        "", // this URL was not concatenated with the group prefix, 
        "CmsAdmin_Articles");
    routes.Add("Preview", 
        "articles/preview", 
        "some_valid_virtual_path", // this cannot be null and requires a valid embedded resource path even though it is not used 
        presenterFactory: _ => new PreviewPopupPresenter());
});

@tomasherceg tomasherceg changed the title Fixed bug in route groups Refactoring & cleanup in routes & route groups + bug fixes Apr 26, 2025
@tomasherceg tomasherceg added this to the Version 5.0 milestone Apr 26, 2025
@tomasherceg tomasherceg merged commit d1141d5 into main Apr 26, 2025
25 of 29 checks passed
@tomasherceg tomasherceg deleted the bug/route-groups branch April 26, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants