Disallow asigning to init-only properties in bindings#1909
Merged
tomasherceg merged 2 commits intomainfrom Mar 16, 2025
Merged
Conversation
exyi
force-pushed
the
not-assign-init-only
branch
from
f306223 to
d9387b2
Compare
tomasherceg
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://forum.dotvvm.com/t/intended-behaviour-coherence-of-init-only-properties-between-c-code-and-dotvvm-front-end/295 for some context. In short, it is OK to allow this in JS code (IMHO we want to simplify staticCommands with records, given that we don't support
with/newyet it's necessary).However, it can be quite dangerous on server, where this might allow you to accidentally mutate a shared singleton object (imagine defining
public static readonly MyRecord Default = new() { ... }and then using it to initialize a view model property)