Merged
Conversation
Member
Author
|
I am not sure if we want to merge it in 4.3 because of binary breaking changes (I've added an optional parameter to the |
exyi
approved these changes
Apr 11, 2025
Member
exyi
left a comment
exyi
left a comment
There was a problem hiding this comment.
👍
I'd avoid merging this to 4.3. If we need it in the 4-something version, we can release some 4.4-preview version
tomasherceg
force-pushed
the
fix/localizable-routes
branch
from
8ad0d05 to
253da7a
Compare
Member
Author
|
I changed this PR to go to 5.0 to prevent confusion. |
tomasherceg
force-pushed
the
fix/localizable-routes
branch
from
04c6e4a to
6c1912f
Compare
tomasherceg
force-pushed
the
fix/localizable-routes
branch
from
6c1912f to
af544de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the localizable routes feature, I discovered two unpleasant things:
Route groups did not have support localized route fragments.
The
IsPartialMatchmethod did not return which culture was matched. I needed that when using ASP.NET Core's Request Localization feature to be able to determine the culture from the URL.