Fix of race condition in compilation of markup controls with property directives#1924
Merged
tomasherceg merged 2 commits intomainfrom Apr 26, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a race condition in the dynamic compilation of markup controls by adding proper synchronization and error handling.
- Introduces a locking mechanism around dynamic type creation in ResolvedPropertyDeclarationDirectiveCompiler.cs
- Enhances error handling with a try-catch block to wrap dynamic type creation exceptions in a more informative InvalidOperationException
- Updates hash generation in PropertyDeclarationDirectiveCompiler.cs to ensure valid type names
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Framework/Framework/Compilation/Directives/ResolvedPropertyDeclarationDirectiveCompiler.cs | Adds a locking mechanism and error handling to prevent race conditions in dynamic type creation |
| src/Framework/Framework/Compilation/Directives/PropertyDeclarationDirectiveCompiler.cs | Modifies hash generation for type names by replacing characters to maintain valid naming |
Comments suppressed due to low confidence (1)
src/Framework/Framework/Compilation/Directives/ResolvedPropertyDeclarationDirectiveCompiler.cs:15
- [nitpick] Consider renaming 'locker' to a more descriptive name like 'dynamicAssemblyLock' to improve clarity in its purpose.
private static readonly object locker = new();
exyi
approved these changes
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.