Fix default values of PostbackScriptOptions#1926
Merged
tomasherceg merged 1 commit intomainfrom May 30, 2025
Merged
Conversation
Resolves #1908 We now store all options as nullable, and the default value is determined by the KnockoutHelper function called. It is necessary, as GenerateClientPostbackLambda has a different set of default values than GenerateClientPostbackLambda, and GenerateClientPostbackScript. Notable exception is the ReturnValue, which already is nullable and null means that `null` should be returned. It's thus technically difficult to make this property "optional", and this issue isn't really relevant for this property anyway
tomasherceg
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1908
We now store all options as nullable, and the default value is determined by the KnockoutHelper function called. It is necessary, as GenerateClientPostbackLambda has a different set of default values than GenerateClientPostbackLambda, and GenerateClientPostbackScript.
Notable exception is the ReturnValue, which already is nullable and null means that
nullshould be returned. It's thus technically difficult to make this property "optional", and this issue isn't really relevant for this property anyway