feat!: use gzip compression for grpc #526
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
Would it be possible to use content negotiation to determine whether compression is supported? (See also MDN: Compression) Edit: This is mostly a question of whether |
Contributor
Author
|
As far as I can tell, the grpc compression spec I linked above essentially describes a form of content negotiation, using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: conserv does not support this yet, so ultimately we'll need to cache a flag somewhere indicating if compression is supported, and set it to
falseif we get a "compression not supported" response. See https://grpc.github.io/grpc/core/md_doc_compression.html