fix: test all python releases individually, use manylinux 2_34 #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
|
Testing locally with this: # on my host machine
docker run -it --platform="linux/x86_64" --entrypoint /bin/bash -v $(pwd):/code --network="host" quay.io/pypa/manylinux_2_34_x86_64:latest
# inside container
export CXXFLAGS="-std=c++11"
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
. "$HOME/.cargo/env"
cargo install cargo-make
cd /code/crates/python
rm -rf .venv
python3.9 -m venv .venv
source .venv/bin/activate
cargo make install-deps
maturin build -i 3.9 --release |
jselig-rigetti
commented
Feb 10, 2025
| uses: messense/maturin-action@v1 | ||
| with: | ||
| manylinux: '2_28' | ||
| manylinux: '2_34' |
Contributor
Author
There was a problem hiding this comment.
This seemed to be the fix in https://github.com/rigetti/qcs-sdk-rust/actions/runs/13248276833
jselig-rigetti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#532 wheels apparently aren't building correctly in
python 3.9this will at least test installing them in all environments.