Dev #13
Merged
Dev #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version to 1.0.4 and refactors the LoRa transmission timeout calculation and channel busy backoff logic in the SX1262 radio driver. The changes align the Python implementation with a C++ MeshCore formula for more accurate timing calculations.
- Version updated from 1.0.3 to 1.0.4 across all relevant files
- Replaced approximate timeout calculation with precise LoRa airtime formula
- Improved channel busy backoff with exponential backoff strategy
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/test_basic.py | Updated version assertion to match new 1.0.4 version |
| src/pymc_core/init.py | Bumped package version to 1.0.4 |
| pyproject.toml | Updated project version to 1.0.4 |
| src/pymc_core/hardware/sx1262_wrapper.py | Refactored TX timeout calculation using LoRa airtime formula and improved backoff logic with exponential backoff |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak TX timing and update, and fine tune LBT slightly.