bump version to 1.0.1 add new board #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rightup
commented
Oct 24, 2025
rightup
commented
- New board
- new waveshare flag > is_waveshare: bool set special setup
- updated text MSG processing path
- tidy some code formatting
…, instead of assuming only Waveshare uses CS on GPIO21
Add an explicit flag to the radio configuration for the Waveshare HAT…
update to calc in kHz Co-authored-by: Copilot <[email protected]>
Update to comment Co-authored-by: Copilot <[email protected]>
update The setup instructions incorrectly reference 'Waveshare SX1262 HAT' when it should refer to the 'Frequency Labs meshadv-mini HAT' to match the section heading. Co-authored-by: Copilot <[email protected]>
Added meshadv mini radio profile and tested on hardware
Improvements to - ACK flow, Timing and text message path handler logic
Hardware/meshadv
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the version to 1.0.1 and adds support for the FrequencyLabs meshadv-mini board. Key changes include:
- Added
is_waveshareflag to enable specialized initialization for Waveshare HAT hardware - Updated text message processing to support both FLOOD and DIRECT routing with appropriate ACK responses using timing calculations
- Added
PacketTimingUtilsclass for LoRa airtime estimation and timeout calculations - Added meshadv-mini board configuration throughout examples and documentation
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pymc_core/init.py | Version bump to 1.0.1 |
| pyproject.toml | Version bump to 1.0.1 |
| src/pymc_core/hardware/sx1262_wrapper.py | Added is_waveshare parameter for specialized board initialization |
| src/pymc_core/protocol/packet_utils.py | Added PacketTimingUtils class and fixed SNR calculation; updated routing logic |
| src/pymc_core/protocol/packet_builder.py | Updated text message creation with enhanced debug logging; fixed advert name padding and path encryption |
| src/pymc_core/node/handlers/text.py | Refactored message handling to support FLOOD/DIRECT routing with timing-based ACK delays |
| src/pymc_core/node/node.py | Added radio_config parameter passing |
| src/pymc_core/node/dispatcher.py | Added radio_config parameter to handler registration |
| examples/common.py | Added meshadv-mini configuration; updated waveshare GPIO pins |
| docs/docs/node.md | Added meshadv-mini documentation and updated configuration tables |
| docs/docs/examples.md | Added meshadv-mini to hardware requirements and examples |
| README.md | Added meshadv-mini to supported radios list; updated Discord link |
| Multiple test files | Code formatting updates (line length consolidation) |
| Multiple handler files | Code formatting updates (line length consolidation) |
| Multiple LoRa driver files | Code formatting updates (line length consolidation) |
| .pre-commit-config.yaml | Added E231 to flake8 ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+54
to
+55
| "txen_pin": 13, # GPIO 13 for TX enable | ||
| "rxen_pin": 12, |
There was a problem hiding this comment.
Changed waveshare configuration from txen_pin: 6 to txen_pin: 13 and added rxen_pin: 12 (was -1). This is a significant hardware configuration change that may break existing waveshare HAT setups. Ensure this change is documented in release notes and that users are aware they may need to update their hardware configuration.
Co-authored-by: Copilot <[email protected]>
Owner
Author
|
Bumps the version to 1.0.1 and adds support for the FrequencyLabs meshadv-mini board. Key changes include: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.