Fix LDRO configuration and add automatic detection for SF8+ with narrow bandwidth #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…row bandwidth Add automatic LDRO calculation and configuration based on symbol duration. LDRO must be enabled when symbol duration > 16ms to prevent timing drift and CRC errors during reception. - Calculate symbol duration: 2^SF / (BW / 1000) milliseconds - Enable LDRO when symbol_duration_ms > 16.0 - Pass ldro parameter to setLoRaModulation() in both Waveshare and standard init paths - Add debug logging to show LDRO state and symbol duration at startup Fixes CRC errors that occurred with SF11/62.5kHz (32.768ms symbols) where LDRO was incorrectly disabled, causing receiver timing drift and packet corruption despite successful transmission. Also improves configuration logging by adding bandwidth to startup message.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes LoRa configuration issues by implementing automatic Low Data Rate Optimization (LDRO) detection and configuration. The primary purpose is to prevent CRC errors that occur with narrow bandwidth configurations (e.g., SF11 with 62.5 kHz) where symbol durations exceed 16ms.
Key changes:
- Automatic LDRO calculation and configuration based on symbol duration threshold (>16ms)
- Enhanced logging with bandwidth information and improved debug verbosity
- New method to retrieve current noise floor measurements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/pymc_core/hardware/sx1262_wrapper.py | Implements LDRO auto-detection logic, adds noise floor getter method, and refines logging levels |
| src/pymc_core/init.py | Version bump to 1.0.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automatic LDRO (Low Data Rate Optimization) calculation and configuration
based on symbol duration to prevent timing drift and CRC errors.
LDRO is now enabled when symbol duration > 16 ms, as per LoRa spec.
This resolves CRC errors observed with SF11 / 62.5 kHz (≈32.768 ms symbols)
where LDRO was previously disabled, causing receiver timing drift and packet corruption.
Changes:
ldroflag tosetLoRaModulation()in both Waveshare and standard init pathsFixes CRC errors on narrow-bandwidth setups (e.g., SF11/62.5kHz).