Replace std::aligned_storage with alignas(T) std::array<Byte, sizeof(T)> #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #49, std::aligned_storage was deprecated in C++23, which causes warnings and/or build errors depending on consuming project settings.
I have tried to implement the proposed migration of using an aligned array of bytes instead.
My local tooling (g++-13) also complained that the code is using a platform specific value, without specifying the value in a compiler flag, so I added
-Wno-interference-sizeto the compiler flags to silence that warning.I'm not sure how to verify if this harms performance of the library. Any pointers or help would be appreciated on that matter.