Conversation
|
where to consolidate utils? have the same functions and lots of repeat since they are the same functionality |
looks like we didnt habe this already so claude code/cursor did some work and i rebuild proto... since its new feature it shouldnt effect anything else
|
@begelundmuller , based on Mike's requests to add push-pull button in the UI here: https://rilldata.slack.com/archives/C01A9DYP013/p1765989576246559?thread_ts=1765901488.470909&cid=C01A9DYP013 required some new backend changes, so tagging you as a reviewer for this PR, as well. If this is "too complicated" or adds brittleness to the code base, we can remove the backend changes and buttons for this PR and tackle it in a dedicated PR in the future. Thoughts? |
begelundmuller
left a comment
There was a problem hiding this comment.
The backend code here seems correct at a high level, although it could do with some cleaning up (there are some anti-patterns and no tests)
Code ReviewProfessionalism & Code Quality: ⭐⭐⭐⭐⭐ (Excellent)Strengths:
Issues to Address:
E2E Testing:
|
|
Just spoke to Mike and got confirmed that we want this in UI |



Before Deploy:
After Deploy:
Code view Before Deploy:

Checklist: