Skip to content

Conversation

@lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Jan 13, 2026

This PR refactors all connector forms to use a unified JSON schema-based validation and rendering system, replacing the previous Yup-based validation approach.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus self-assigned this Jan 13, 2026
@lovincyrus lovincyrus force-pushed the cyrus/all-connectors-json-schema branch from 274c8cd to 45c3e9f Compare January 13, 2026 22:59
@lovincyrus lovincyrus requested a review from royendo January 14, 2026 18:54
@royendo
Copy link
Contributor

royendo commented Jan 14, 2026

bug:
when athen errors, typing doesnt clear error
Screenshot 2026-01-14 at 15 42 13

nit:
bigquery should not have project-id as optional, errors if its not there
also a Title like AWS Access Key ID in athena would be great "GCP Credential", "Service Account JSON", etc.
Screenshot 2026-01-14 at 15 42 16

Are we not going to add HTTPS connector as two step in this PR? fine to do in in another, but we're already here so might as well.

Seeing we removed clickhosue specific forms, can we also split clickhouse-cloud and clickhouse into separate .ts?
same with adding two step here, we're already in the .ts files (but thats just my Product opinion, defer to @ericpgreen2 for code work)

Copy link
Contributor

@royendo royendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above :)

@lovincyrus
Copy link
Contributor Author

bug: when athen errors, typing doesnt clear error Screenshot 2026-01-14 at 15 42 13

nit: bigquery should not have project-id as optional, errors if its not there also a Title like AWS Access Key ID in athena would be great "GCP Credential", "Service Account JSON", etc. Screenshot 2026-01-14 at 15 42 16

Addressed both! The main focus of this branch is to land the schema-driven design for all connectors. I plan to tackle others when the base branch is clean.

@lovincyrus lovincyrus requested a review from royendo January 14, 2026 23:20
@lovincyrus lovincyrus marked this pull request as ready for review January 14, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants