Skip to content

Make Github webhooks trigger the parser for deployments in updating state #8690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
begelundmuller merged 1 commit into from
Jan 23, 2026
Merged

Make Github webhooks trigger the parser for deployments in updating state #8690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions admin/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,9 @@ func (s *Service) processGithubPush(ctx context.Context, event *github.PushEvent
// Don't trigger runtime reconcile for dev deployments, let the user manually pull changes to avoid any conflicts
continue
}
// We don't trigger runtime reconcile if the deployment is not ready
if depl.Status != database.DeploymentStatusRunning {
// Only trigger a reconcile for running/updating deployments.
// NOTE: Including "updating" here to avoid race conditions when there's a push and env config update happening simultaneously.
if depl.Status != database.DeploymentStatusRunning && depl.Status != database.DeploymentStatusUpdating {
s.Logger.Info("process github event: runtime reconcile not triggered, deployment is not ready", zap.String("project_id", project.ID), zap.String("deployment_id", depl.ID), zap.String("deployment_status", depl.Status.String()), observability.ZapCtx(ctx))
continue
}
Expand Down
Loading