Added member xxx_notify() to class Context and catch exception to stop the propagation#1066
Open
shewer wants to merge 49 commits intorime:masterfrom
Open
Added member xxx_notify() to class Context and catch exception to stop the propagation#1066shewer wants to merge 49 commits intorime:masterfrom
shewer wants to merge 49 commits intorime:masterfrom
Conversation
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
…the propagation Signed-off-by: shewer <shewer@gmail.com>
Member
|
可能有一定幫助吧。但是我也注意到 |
Signed-off-by: shewer <shewer@gmail.com>
Contributor
Author
已在 Context 加入 connect method 了， 也改了librime 中中有使用 notify 的code , 但沒有移除 notifier 外露 ，因為librime-lua script 還有在使用 notifier |
Member
|
我刚刚看明白这个不是防范异常的。 |
Member
|
究竟要做什么，请讲讲。 如果要实现某个功能，我想了解这个功能的完整设计。 |
Contributor
Author
|
原本只是要增加 Context notify 的接口，你提議想把 notifier 封裝起來，所以我再加上connect 接口. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Added member xxx_notify() to class Context and catch exception to stop the propagation
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info
1 class StopSlotException : public std::runtime_error
2 stop propagation when catch StopSlotException
3 added member in class Context
. commit_notify()
. update_notify()
. select_notify()
. abort_notify()
. option_update_notify(const string&)
. property_update_notify(const string&)
. unhandled_key_notify(const KeyEvent&)