Skip to content

fix: Code Duplication in Validator Management#221

Merged
ISTIFANUS-N merged 1 commit intorinafcode:mainfrom
MerlinTheWhiz:fix/validation-management-code-duplication
Mar 30, 2026
Merged

fix: Code Duplication in Validator Management#221
ISTIFANUS-N merged 1 commit intorinafcode:mainfrom
MerlinTheWhiz:fix/validation-management-code-duplication

Conversation

@MerlinTheWhiz
Copy link
Copy Markdown
Contributor

Closes #147

Changes I made:

  • Updated: lib.rs — made validator_utils public and gated property-based tests.
  • Updated: validator_utils.rs — fixed comparator bug in remove_validator_from_list.
  • Added: validator_utils_harness.rs — new focused integration test. I had to separate it because there are a lot of errors in the rest.

Screenshot of test passing:
image

@github-actions
Copy link
Copy Markdown

🎉 Welcome to TeachLink, @MerlinTheWhiz!

Thank you for your first contribution! A maintainer will review your PR soon.

While you wait:

  • Make sure all CI checks pass ✅
  • Review the PR checklist
  • Join our Discord to connect with the community

We appreciate your contribution to decentralized education! 🎓

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 30, 2026

@MerlinTheWhiz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@ISTIFANUS-N ISTIFANUS-N merged commit 45bb837 into rinafcode:main Mar 30, 2026
5 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code Duplication in Validator Management

2 participants