-
Notifications
You must be signed in to change notification settings - Fork 0
add a whitelist of domains for links in content #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
persd
wants to merge
6
commits into
astro
Choose a base branch
from
feature/whitelist-domains-for-content-links
base: astro
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b53cac7
add whitelisted domains for content links
persd d7aebb3
fix
persd 7c5d5b5
fix
persd 8c7c416
add whitelist for content links
persd 27c42af
fix
persd 4f9ec6b
Merge branch 'astro' of https://github.com/ringpublishing/hat-compone…
persd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| import { AppContext } from "../../types/types"; | ||
| import { ConfigHelper_getContentLinksConfig } from "../ConfigHelper"; | ||
|
|
||
| interface WhitelistedDomain { | ||
| domain: string; | ||
| relAttribute?: string; | ||
| } | ||
|
|
||
| interface ContentLinksConfig { | ||
| enableDomainWhitelist?: boolean; | ||
| whitelistedDomains?: WhitelistedDomain[]; | ||
| } | ||
|
|
||
| const LINK_REGEX = /<a\s+[^>]*?href=["'](https?:\/\/[^"']+)["'][^>]*?>/gi; | ||
| const REL_REGEX = /\s+rel=["']([^"']*)["']/i; | ||
|
|
||
| export async function SeoLinkWhitelistHelper_processLinks(context: AppContext, text: string): Promise<string> { | ||
| if (!text) { | ||
| return text; | ||
| } | ||
|
|
||
| try { | ||
| const contentLinksConfig = await ConfigHelper_getContentLinksConfig(context) as ContentLinksConfig; | ||
| const whitelistedDomainsList = contentLinksConfig?.whitelistedDomains; | ||
|
|
||
| if (!contentLinksConfig?.enableDomainWhitelist || !whitelistedDomainsList?.length) { | ||
| return text; | ||
| } | ||
|
|
||
| const whitelistedDomains = whitelistedDomainsList | ||
| .filter((item) => item.domain?.trim()) | ||
| .map((item) => ({ | ||
| ...item, | ||
| domain: item.domain.trim().toLowerCase() | ||
| })); | ||
persd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if (whitelistedDomains.length === 0) { | ||
| return text; | ||
| } | ||
|
|
||
| return text.replace(LINK_REGEX, (matchedLink, href) => { | ||
| let domain: string; | ||
| try { | ||
| domain = new URL(href).hostname.toLowerCase(); | ||
| } catch { | ||
| return matchedLink; | ||
| } | ||
|
|
||
| const matchWithWhitelist = whitelistedDomains.find((item) => | ||
| domain === item.domain || domain.endsWith(`.${item.domain}`) | ||
| ); | ||
|
|
||
| const existingRelMatch = matchedLink.match(REL_REGEX); | ||
| const currentRelAttributes = existingRelMatch?.[1] | ||
| ? existingRelMatch[1].split(/\s+/).filter(Boolean) | ||
| : []; | ||
|
|
||
| if (matchWithWhitelist) { | ||
| // Remove nofollow for whitelisted domains | ||
| const filtered = currentRelAttributes.filter((attr) => attr !== "nofollow"); | ||
|
|
||
| // Add configured rel attributes | ||
| if (matchWithWhitelist.relAttribute) { | ||
| const configAttrs = matchWithWhitelist.relAttribute.toLowerCase().split(/\s+/).filter(Boolean); | ||
| configAttrs.forEach((attr) => { | ||
| if (!filtered.includes(attr)) { | ||
| filtered.push(attr); | ||
| } | ||
| }); | ||
| } | ||
| currentRelAttributes.length = 0; | ||
| currentRelAttributes.push(...filtered); | ||
| } else { | ||
| // Add nofollow for non-whitelisted domains | ||
| if (!currentRelAttributes.includes("nofollow")) { | ||
| currentRelAttributes.push("nofollow"); | ||
| } | ||
| } | ||
|
|
||
| const newRelString = currentRelAttributes.length > 0 | ||
| ? ` rel="${currentRelAttributes.join(" ")}"` | ||
| : ""; | ||
|
|
||
| if (existingRelMatch) { | ||
| return matchedLink.replace(REL_REGEX, newRelString); | ||
| } | ||
|
|
||
| if (newRelString) { | ||
| return matchedLink.slice(0, -1) + newRelString + ">"; | ||
| } | ||
|
|
||
| return matchedLink; | ||
| }); | ||
| } catch (error) { | ||
| console.error("SeoLinkWhitelistHelper: Error processing links", error); | ||
| return text; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.