Move version picker to right of component home link #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

colegoldsmith merged 5 commits into main from version-picker-styles

Aug 26, 2024

Collaborator

colegoldsmith commented Aug 21, 2024 •

edited

Loading

A few things:

Move the version picker to the right of the component title link (screenshots below)
I noticed the hashed asset files seem to randomly break the dev preview using gulp preview. I changed the build so it doesn't hash the files when running that, it's not necessary there anyway.

Screenshot 2024-08-26 at 2 41 55 PM

Screenshot 2024-08-26 at 2 42 35 PM

Screenshot 2024-08-26 at 2 42 15 PM

Testing

This is a little hard to test because the Antora site build for this repo does not include any of the content repos that have versions. We won't be able to see this update until we make the full site preview build when making a PR to update the UI bundle. To test my changes here I ran a local build with a few content sources that have versions and a local UI bundle of these changes.


          move version picker to right of component home link

b8c1f17

Contributor

mlr commented Aug 21, 2024 •

edited

Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview


          add all items to breadcrumbs trail

5be8466

Contributor

mlr commented Aug 21, 2024 •

edited

Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

Contributor

mlr commented Aug 22, 2024 •

edited

Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

mlr mentioned this pull request

Wider versions dropdown #152

Closed


          remove latest text on select and shrink font size

2c933f3

Contributor

mlr commented Aug 22, 2024 •

edited

Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

Contributor

mlr commented Aug 22, 2024 •

edited

Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

colegoldsmith mentioned this pull request

Add component title to left nav #134

Closed


          remove assets-manifest and hashing for preview mode

31b9482

Contributor

mlr commented Aug 26, 2024 •

edited

Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

plpesvc-ds commented Aug 26, 2024 •

edited

Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft


          revert changes to breadcrumbs

Contributor

mlr commented Aug 26, 2024 •

edited

Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

plpesvc-ds commented Aug 26, 2024 •

edited

Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

eric-schneider approved these changes

View reviewed changes

colegoldsmith merged commit 872bf0a into main

2 checks passed

colegoldsmith deleted the version-picker-styles branch

August 26, 2024 20:32

colegoldsmith linked an issue

that may be closed by this pull request

Awkward text wrapping in version picker #149

Closed

eric-schneider mentioned this pull request

Awkward text wrapping in version picker #149

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet