Skip to content

Commit 04124c7

Browse files
committed
target: fix memory leak in handle_target_write_memory()
Commit f55ec6d ("target: rewrite command 'write_memory' as COMMAND_HANDLER") adds a new return statement without freeing the allocated buffer. Add the needed free(). Fixes: f55ec6d ("target: rewrite command 'write_memory' as COMMAND_HANDLER") Change-Id: I676d658118b32f4d7cc71eda3436bb52f1966cd8 Signed-off-by: Antonio Borneo <[email protected]> Reviewed-on: https://review.openocd.org/c/openocd/+/8822 Tested-by: jenkins
1 parent 169d463 commit 04124c7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/target/target.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4608,6 +4608,7 @@ COMMAND_HANDLER(handle_target_write_memory)
46084608
int jimretval = Jim_GetWide(CMD_CTX->interp, tmp, &element_wide);
46094609
if (jimretval != JIM_OK) {
46104610
command_print(CMD, "invalid value \"%s\"", Jim_GetString(tmp, NULL));
4611+
free(buffer);
46114612
return ERROR_COMMAND_ARGUMENT_INVALID;
46124613
}
46134614

0 commit comments

Comments
 (0)