Update HSOC_020 to clarify peripherals#95
Merged
jones-drew merged 1 commit intoriscv-non-isa:mainfrom Sep 30, 2025
Merged
Conversation
jones-drew
requested changes
Sep 30, 2025
server_platform_requirements.adoc
Outdated
| | `HSOC_020` | All SoC peripherals that are intended by the platform design to | ||
| be assignable to a virtual machine or exposed to a user-space device driver MUST be | ||
| PCIe devices or comply with the rules for SoC-integrated PCIe devices (cite:[ServerSoC], Section 2.4). | ||
| 2+| _This rule does not apply to components such as: |
Collaborator
There was a problem hiding this comment.
How about
This rule does not apply to components not typically intended by the platform for virtual machine or user-space assignment such as:
...
since I think the point of the list is to be examples of non-assignable devices, rather than assignable-devices that may be exempted from the rule.
Collaborator
There was a problem hiding this comment.
Also need "a" to the cell properties to get the unordered list to render correctly, which then also requires changing how the italics are created. The final result of my suggestions are
diff --git a/server_platform_requirements.adoc b/server_platform_requirements.adoc
index 2b53c537f4a1..4ae907d33a74 100644
--- a/server_platform_requirements.adoc
+++ b/server_platform_requirements.adoc
@@ -114,8 +114,18 @@ in this section apply solely to harts in the application processors of the SoC.
|===
| ID# ^| Rule
| `HSOC_010` | RISC-V SoCs MUST comply with the Server SoC v1.0 specification cite:[ServerSoC].
-| `HSOC_020` | All peripherals that are intended for assignment to a VM or a user space device driver MUST be
-PCIe devices or be compliant to rules for SoC-integrated PCIe devices (cite:[ServerSoC], Section 2.4).
+| `HSOC_020` | All SoC peripherals that are intended by the platform design to
+be assignable to a virtual machine or exposed to a user-space device driver MUST be
+PCIe devices or comply with the rules for SoC-integrated PCIe devices (cite:[ServerSoC], Section 2.4).
+2+a| _This rule does not apply to components not typically intended by the platform
+ for virtual machine or user-space assignment such as:_
+
+ * _Interrupt controllers (e.g., APLIC)._
+ * _IOMMUs._
+ * _Debug modules, trace control blocks, RAS banks, and performance
+ monitoring units._
+ * _Controllers, including the root of trust (RoT) controllers,
+ power management controllers, and other SoC management controllers._
|===
=== Peripherals
cfd8057 to
fa85711
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.