[WIP] Move some Server SoC ACPI validation tests to Server Platform#98
Open
paul-walmsley-sifive wants to merge 2 commits intoriscv-non-isa:mainfrom
Conversation
Note that the Server Platform Test Specification will include some tests of referenced specifications, using some features specified in the Server Platform specification, and/or features specified in specifications that are included in the Server Platform specification by reference. These tests use a "C" character for the test type (denoting that they are composite tests). Remove a comment that most tests simply check for the existence of a given feature. While it may be true, this comment seems superfluous, and may rapidly become obsolete. Clean up some whitespace while here.
…est specification The Server SoC test specification, a hardware specification, contains several tests of ACPI table data. These tests do not actually test anything specified in the Server SoC specification. Since they do test products of requirements stated in the Server Platform specification, either directly or by reference, move these tests to the Server Platform specification.
paul-walmsley-sifive
changed the title
paul-walmsley-sifive
added a commit
to paul-walmsley-sifive/server-soc
that referenced
this pull request
Oct 7, 2025
…ecification The Server SoC Test specification contains several ACPI firmware tests. However, the Server SoC specification is a hardware specification, and places no requirements directly on firmware. That is done by the Server Platform specification, which includes the Server SoC specification by reference, and which also includes the ACPI specification by referencing the Boot and Runtime Services specification (using the BRS-I profile). As a result, these ACPI firmware tests don't belong in the Server SoC Test specification. We wish to preserve the ACPI firmware validation tests, so, move these tests to the Server Platform specification. See riscv-non-isa/riscv-server-platform#98 for the corresponding Server Platform specification pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Server SoC Test Specification contains some ACPI firmware tests that aren't directly specified by the Server SoC specification (which has nothing to do with ACPI), but which are specified by the Server Platform specification (often by references). So, move these ACPI firmware tests into the Server Platform test specification.
This pull request is a work-in-progress and is not yet ready for merging.